Greg Padgett has posted comments on this change. Change subject: core: introduce RemoveSnapshotSingleDiskLive BLL command ......................................................................
Patch Set 12: (1 comment) http://gerrit.ovirt.org/#/c/26909/12/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MergeCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MergeCommand.java: Line 36: createVDSParameters()); Line 37: Line 38: if (vdsReturnValue.getSucceeded()) { Line 39: Guid jobId = (Guid) vdsReturnValue.getReturnValue(); Line 40: persistBlockJobPlaceholder(jobId); > Shouldn't we persist the job before sending the request? Is there another a Infra doesn't provide an additional placeholder, but we can use the command itself for that. The vmJob placeholder is only used to synchronize with VURTI. VURTI is only allowed to update/delete vmJobs that are already in the database at the time it queries the vmStats, so by putting the placeholder after the command VURTI will never mistakenly remove a vmJob when one is actually in progress. However, I think there is a missing piece, in case the server crashes between MergeVDSCommand execution and insertion of the vmJob placeholder. I'll add code in the doPolling() callback to add the placeholder if it's missing, which should take care of that. Does that take care of your concerns? Line 41: getParameters().setVmJobId(jobId); Line 42: persistCommand(getParameters().getParentCommand(), true); Line 43: } else { Line 44: log.error("Failed to start Merge on VDS"); -- To view, visit http://gerrit.ovirt.org/26909 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic47eb91a0ea1fe150e3b2152e2c9d5f1f2eb3678 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
