Federico Simoncelli has posted comments on this change. Change subject: core: introduce RemoveSnapshotSingleDiskLive BLL command ......................................................................
Patch Set 12: (1 comment) http://gerrit.ovirt.org/#/c/26909/12/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MergeCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MergeCommand.java: Line 36: createVDSParameters()); Line 37: Line 38: if (vdsReturnValue.getSucceeded()) { Line 39: Guid jobId = (Guid) vdsReturnValue.getReturnValue(); Line 40: persistBlockJobPlaceholder(jobId); Shouldn't we persist the job before sending the request? Is there another automatic placeholder provided by the infra? Line 41: getParameters().setVmJobId(jobId); Line 42: persistCommand(getParameters().getParentCommand(), true); Line 43: } else { Line 44: log.error("Failed to start Merge on VDS"); -- To view, visit http://gerrit.ovirt.org/26909 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic47eb91a0ea1fe150e3b2152e2c9d5f1f2eb3678 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
