Allon Mureinik has posted comments on this change. Change subject: core: introduce RemoveSnapshotSingleDiskLive BLL command ......................................................................
Patch Set 10: Code-Review+1 (2 comments) http://gerrit.ovirt.org/#/c/26909/10/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DestroyImageCommandCallback.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DestroyImageCommandCallback.java: Line 21: AsyncTasks task = TaskManagerUtil.getAsyncTaskFromDb(cmd.getParameters().getVdsmTaskIds().get(0)); Line 22: if (task.getstatus() == AsyncTaskStatusEnum.finished) { Line 23: log.errorFormat("GP LOG DestroyImageCommandCallback.doPolling(), command status is {0}, async task result is {1}", cmd.getCommandStatus(), task.getresult()); Line 24: // TODO GP ravi says remove Line 25: //cmd.setCommandStatus(task.getresult() == AsyncTaskResultEnum.success ? CommandStatus.SUCCEEDED : CommandStatus.FAILED); so please do :-) Line 26: } Line 27: log.error("GP LOG DestroyImageCommandCallback.doPolling() finish"); Line 28: } Line 29: http://gerrit.ovirt.org/#/c/26909/10/backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties File backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties: Line 406: DEACTIVATE_NIC_FAILED=Failed to deactivate VM Network Interface. Line 407: UPDATE_VNIC_FAILED=Failed to update VM Network Interface. Line 408: VolumeResizeValueError=Incorrect size value for volume resize Line 409: ResizeErr=Wrong resize disk parameter Line 410: UpdateDevice=Failed to update device Did you mean to remove SETUP_NETWORKS_ROLLBACK? -- To view, visit http://gerrit.ovirt.org/26909 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic47eb91a0ea1fe150e3b2152e2c9d5f1f2eb3678 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
