Alon Bar-Lev has posted comments on this change. Change subject: aaa: Failure in adding users via REST-API ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/28685/1/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthzUtils.java File backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthzUtils.java: Line 290: directoryUser = new DirectoryUser( Line 291: extension.getContext().<String> get(Base.ContextKeys.INSTANCE_NAME), Line 292: principalRecord.<String> get(Authz.PrincipalRecord.NAMESPACE), Line 293: principalRecord.<String> get(Authz.PrincipalRecord.ID), Line 294: name.contains("@") ? name.substring(0, name.indexOf("@")) : name > Hi, and here, the function should get y...@ovirt.org, the @someprofile should be stripped at higher levels. Line 295: ); Line 296: directoryUser.setDepartment(principalRecord.<String> get(Authz.PrincipalRecord.DEPARTMENT)); Line 297: directoryUser.setFirstName(principalRecord.<String> get(Authz.PrincipalRecord.FIRST_NAME)); Line 298: directoryUser.setLastName(principalRecord.<String> get(Authz.PrincipalRecord.LAST_NAME)); -- To view, visit http://gerrit.ovirt.org/28685 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I81ce111439c1647b13ef8ec6fcad169fd5feead6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
