Oved Ourfali has posted comments on this change. Change subject: aaa: Failure in adding users via REST-API ......................................................................
Patch Set 1: Code-Review+1 (1 comment) See question. Just making sure the search query is used always I the same pattern. http://gerrit.ovirt.org/#/c/28685/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java: Line 178: Line 179: if (atIndex > eqIndex) { Line 180: searchPattern = searchPattern.substring(0, atIndex); Line 181: } Line 182: getParameters().setSearchPattern(searchPattern); > username in REST-API is in format of user@api, in previous versions as well Is the search query here only in the format you have mentioned? Can't it be for multiple users/groups? Line 183: QueryData data = initQueryData(true); Line 184: if (data == null) { Line 185: return Collections.emptyList(); Line 186: } -- To view, visit http://gerrit.ovirt.org/28685 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I81ce111439c1647b13ef8ec6fcad169fd5feead6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
