Yair Zaslavsky has posted comments on this change. Change subject: aaa: Failure in adding users via REST-API ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/28685/1/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthzUtils.java File backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthzUtils.java: Line 290: directoryUser = new DirectoryUser( Line 291: extension.getContext().<String> get(Base.ContextKeys.INSTANCE_NAME), Line 292: principalRecord.<String> get(Authz.PrincipalRecord.NAMESPACE), Line 293: principalRecord.<String> get(Authz.PrincipalRecord.ID), Line 294: name.contains("@") ? name.substring(0, name.indexOf("@")) : name > I do not understand how come /domain/xxx/users have profile within... as th Hi, first of all, you do not have the profile but the authz (domain). For example - with AD we return principalName and map it eventually (via LdapUser, via ExtMap to DirectoryUser) to DirectoryUser.name. the principalName contains for example - y...@ovirt.org - on top of that API adds (and actually always added) the domain - so you get y...@ovirt.org@somedomain. I hope this made a bit clear. Line 295: ); Line 296: directoryUser.setDepartment(principalRecord.<String> get(Authz.PrincipalRecord.DEPARTMENT)); Line 297: directoryUser.setFirstName(principalRecord.<String> get(Authz.PrincipalRecord.FIRST_NAME)); Line 298: directoryUser.setLastName(principalRecord.<String> get(Authz.PrincipalRecord.LAST_NAME)); http://gerrit.ovirt.org/#/c/28685/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java: Line 178: Line 179: if (atIndex > eqIndex) { Line 180: searchPattern = searchPattern.substring(0, atIndex); Line 181: } Line 182: getParameters().setSearchPattern(searchPattern); > Is the search query here only in the format you have mentioned? Can't it be I have checked, and it works for getting alll the users from the domain. Line 183: QueryData data = initQueryData(true); Line 184: if (data == null) { Line 185: return Collections.emptyList(); Line 186: } -- To view, visit http://gerrit.ovirt.org/28685 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I81ce111439c1647b13ef8ec6fcad169fd5feead6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
