Yair Zaslavsky has posted comments on this change. Change subject: engine : Add quartz to handle AsycCommands ......................................................................
Patch Set 26: (2 comments) http://gerrit.ovirt.org/#/c/28160/26/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandExecutor.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandExecutor.java: Line 47: Line 48: @OnTimerMethodAnnotation("invokeCallbackMethods") Line 49: public synchronized void invokeCallbackMethods() { Line 50: initCommandExecutor(); Line 51: for (Guid cmdId : cmdCallBackMap.keySet()) { Looks good! Line 52: CommandCallBack callBack = cmdCallBackMap.get(cmdId); Line 53: CommandStatus status = coco.getCommandStatus(cmdId); Line 54: switch(status) { Line 55: case FAILED: http://gerrit.ovirt.org/#/c/28160/26/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/CommandEntityDao.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/CommandEntityDao.java: Line 11: void saveOrUpdate(CommandEntity commandEntity); Line 12: Line 13: void updateStatus(Guid command, CommandStatus status); Line 14: Line 15: void updateNotified(Guid id, boolean notified); HI, Can you cancel notification? maybe updateNotified(Guid id) is enough? Line 16: Line 17: void removeAllBeforeDate(Date cutoff); Line 18: -- To view, visit http://gerrit.ovirt.org/28160 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I66b1e5945884aec412ba412e39266129004d7218 Gerrit-PatchSet: 26 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
