Yair Zaslavsky has posted comments on this change. Change subject: engine : Add quartz to handle AsycCommands ......................................................................
Patch Set 23: (4 comments) http://gerrit.ovirt.org/#/c/28160/23/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java: Line 1304: public Void runInTransaction() { Line 1305: buildChildCommandInfos(); Line 1306: for (Map.Entry<Guid, Pair<VdcActionType, VdcActionParametersBase>> entry : childCommandInfoMap.entrySet()) { Line 1307: CommandBase<?> command = Line 1308: BackendUtils.getBackendCommandObjectsHandler(log).createAction(entry.getValue().getFirst(), In the previous patch you were performing JNDI lookup to this bean somewhere else (I think) - can you make sure that that patch uses this BackendUtils as well? Line 1309: entry.getValue().getSecond()); Line 1310: command.insertAsyncTaskPlaceHolders(); Line 1311: childCommandsMap.put(entry.getKey(), command); Line 1312: } http://gerrit.ovirt.org/#/c/28160/23/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandsCacheImpl.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandsCacheImpl.java: Line 74: } Line 75: } Line 76: Line 77: Line 78: public void updateCallBackNotified(Guid commandId, boolean notified) { can you please explain this method? Line 79: CommandEntity cmdEntity = get(commandId); Line 80: if (cmdEntity != null) { Line 81: cmdEntity.setCallBackNotified(notified); Line 82: DbFacade.getInstance().getCommandEntityDao().updateNotified(commandId, notified); http://gerrit.ovirt.org/#/c/28160/23/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/BackendUtils.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/BackendUtils.java: Line 6: import javax.naming.InitialContext; Line 7: import javax.naming.NamingException; Line 8: Line 9: public class BackendUtils { Line 10: public static final String BACKEND_COMMAND_OBJECTS_HANDLER_JNDI_NAME = awesome, now make sure that we use it in all relevnt places :) Line 11: "java:global/engine/bll/Backend!org.ovirt.engine.core.bll.interfaces.BackendCommandObjectsHandler"; Line 12: /** Line 13: * This method should be used only at {@link BackendUtils} code for creating Line 14: * and execution {@link BackendUtils} objects directly. http://gerrit.ovirt.org/#/c/28160/23/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/CommandEntity.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/CommandEntity.java: Line 17: private VdcActionParametersBase actionParameters; Line 18: private Date createdAt; Line 19: private CommandStatus commandStatus = CommandStatus.UNKNOWN; Line 20: private boolean callBackEnabled = false; Line 21: private boolean callBackNotified = false; see previous question - can you please explain more about this flags? Line 22: Line 23: @Override Line 24: public int hashCode() { Line 25: final int prime = 31; -- To view, visit http://gerrit.ovirt.org/28160 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I66b1e5945884aec412ba412e39266129004d7218 Gerrit-PatchSet: 23 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
