Ravi Nori has posted comments on this change. Change subject: engine : Add quartz to handle AsycCommands ......................................................................
Patch Set 23: (1 comment) Will handle BackendUtils bean look up too. http://gerrit.ovirt.org/#/c/28160/23/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandsCacheImpl.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandsCacheImpl.java: Line 74: } Line 75: } Line 76: Line 77: Line 78: public void updateCallBackNotified(Guid commandId, boolean notified) { > can you please explain this method? This update the flag in the database as to weather the call back has been notified that the command has failed/succeeded. This is a way to mark the command as been processed by CommandExecutor. Once updateCallBackNotified has been set to true the command is marked as done. If we dont have this flag we have no way to know if the call back needs to be notified or not. Line 79: CommandEntity cmdEntity = get(commandId); Line 80: if (cmdEntity != null) { Line 81: cmdEntity.setCallBackNotified(notified); Line 82: DbFacade.getInstance().getCommandEntityDao().updateNotified(commandId, notified); -- To view, visit http://gerrit.ovirt.org/28160 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I66b1e5945884aec412ba412e39266129004d7218 Gerrit-PatchSet: 23 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
