Simone Tiraboschi has posted comments on this change. Change subject: packaging: setup: Making engine configuration optional at engine-setup ......................................................................
Patch Set 13: (1 comment) http://gerrit.ovirt.org/#/c/28413/13/packaging/setup/plugins/ovirt-engine-common/ovirt-engine-common/db/pgpass.py File packaging/setup/plugins/ovirt-engine-common/ovirt-engine-common/db/pgpass.py: Line 62: stage=plugin.Stages.STAGE_MISC, Line 63: name=oengcommcons.Stages.DB_CREDENTIALS_AVAILABLE_LATE, Line 64: condition=lambda self: self.environment[ Line 65: oengcommcons.EngineDBEnv.PASSWORD Line 66: ] is not None, > the work of didi should allow each component to ask for database credential if if understood correctly Didi's work it's bit different. engine needs credentials only for its own DB, DWH and reports need credential for their own DB and for the engine one too. Cause, going to install all the three, we don't want to ask the engine DB credentials three time, engine DB credentials are under engine-common so all three can access them. The first that need them will ask, others than can simply use. The problem is just if nobody has never asked. Line 67: ) Line 68: def _misc(self): Line 69: database.OvirtUtils( Line 70: plugin=self, -- To view, visit http://gerrit.ovirt.org/28413 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a7fbc9d2abc141bed49eff20549289cba4a4a61 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
