Simone Tiraboschi has posted comments on this change. Change subject: packaging: setup: Making engine configuration optional at engine-setup ......................................................................
Patch Set 13: (1 comment) http://gerrit.ovirt.org/#/c/28413/13/packaging/setup/plugins/ovirt-engine-common/ovirt-engine-common/db/pgpass.py File packaging/setup/plugins/ovirt-engine-common/ovirt-engine-common/db/pgpass.py: Line 62: stage=plugin.Stages.STAGE_MISC, Line 63: name=oengcommcons.Stages.DB_CREDENTIALS_AVAILABLE_LATE, Line 64: condition=lambda self: self.environment[ Line 65: oengcommcons.EngineDBEnv.PASSWORD Line 66: ] is not None, > so you need to check the engine state, or move this to engine plugin not co we cannon check engine status from engine-common cause otherwise we create an unwanted dependency; it's under engine engine-common cause it's needed also by DWH and reports. If at least one of engine, DWH or reports has been configured on the host, oengcommcons.EngineDBEnv.PASSWORD is not none (it's form didi's re-entrant db credentials patch). If no one of them is in place oengcommcons.EngineDBEnv.PASSWORD is null and we have to skip createPgPass but we also doesn't it. Line 67: ) Line 68: def _misc(self): Line 69: database.OvirtUtils( Line 70: plugin=self, -- To view, visit http://gerrit.ovirt.org/28413 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a7fbc9d2abc141bed49eff20549289cba4a4a61 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
