Sandro Bonazzola has posted comments on this change. Change subject: packaging: setup: Making engine configuration optional at engine-setup ......................................................................
Patch Set 13: (1 comment) http://gerrit.ovirt.org/#/c/28413/13/packaging/setup/plugins/ovirt-engine-common/ovirt-engine-common/db/pgpass.py File packaging/setup/plugins/ovirt-engine-common/ovirt-engine-common/db/pgpass.py: Line 62: stage=plugin.Stages.STAGE_MISC, Line 63: name=oengcommcons.Stages.DB_CREDENTIALS_AVAILABLE_LATE, Line 64: condition=lambda self: self.environment[ Line 65: oengcommcons.EngineDBEnv.PASSWORD Line 66: ] is not None, > ? If you run engine-setup on a clean system and decide to not install the engine you don't have neither a database nor the credentials for accessing it when you run engine-cleanup. So when it call createPgPass it fails not having needed values. This check prevents the failure. Line 67: ) Line 68: def _misc(self): Line 69: database.OvirtUtils( Line 70: plugin=self, -- To view, visit http://gerrit.ovirt.org/28413 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a7fbc9d2abc141bed49eff20549289cba4a4a61 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
