Sandro Bonazzola has posted comments on this change. Change subject: packaging: setup: engine-cleanup split ......................................................................
Patch Set 10: (2 comments) http://gerrit.ovirt.org/#/c/28579/10/packaging/setup/plugins/ovirt-engine-remove/base/files/simple.py File packaging/setup/plugins/ovirt-engine-remove/base/files/simple.py: Line 177: ) Line 178: Line 179: self.environment.setdefault( Line 180: osetupcons.RemoveEnv.REMOVE_SPEC_OPTION_GROUP_LIST, Line 181: [] > mind that using a list here won't allow you to override this by using an an added a todo Line 182: ) Line 183: Line 184: self._infos = sorted( Line 185: glob.glob( http://gerrit.ovirt.org/#/c/28579/10/packaging/setup/plugins/ovirt-engine-remove/ovirt-engine/config/misc.py File packaging/setup/plugins/ovirt-engine-remove/ovirt-engine/config/misc.py: Line 87: 'ca_pki', Line 88: 'iso_domain', Line 89: 'ca_config', Line 90: 'ssl', Line 91: 'versionlock', > no... I mean that we have the information within the uninstall file. added a todo Line 92: ] Line 93: ) Line 94: -- To view, visit http://gerrit.ovirt.org/28579 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I26017770262e313ad38ddfa96baeaea144c86e5f Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
