Alon Bar-Lev has posted comments on this change. Change subject: engine-cleanup split ......................................................................
Patch Set 10: (2 comments) http://gerrit.ovirt.org/#/c/28579/10/packaging/setup/plugins/ovirt-engine-remove/ovirt-engine/config/misc.py File packaging/setup/plugins/ovirt-engine-remove/ovirt-engine/config/misc.py: Line 87: 'ca_pki', Line 88: 'iso_domain', Line 89: 'ca_config', Line 90: 'ssl', Line 91: 'versionlock', we should modify all groups with some engine prefix so we know what they are, then just iterate based on prefix. alternatively have a group of groups. in any case, introduction of new should not effect this file. Line 92: ] Line 93: ) Line 94: http://gerrit.ovirt.org/#/c/28579/10/packaging/setup/plugins/ovirt-engine-remove/ovirt-engine/system/sysctl.py File packaging/setup/plugins/ovirt-engine-remove/ovirt-engine/system/sysctl.py: Line 75: osetupcons.RemoveEnv.REMOVE_ALL Line 76: ] or Line 77: self.environment[ Line 78: oenginecons.RemoveEnv.REMOVE_ENGINE Line 79: ] why don't you set remove engine if remove all is detected at one place? Line 80: ), Line 81: ) Line 82: def _closeup(self): Line 83: if os.path.exists( -- To view, visit http://gerrit.ovirt.org/28579 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I26017770262e313ad38ddfa96baeaea144c86e5f Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
