Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: engine-cleanup split ......................................................................
Patch Set 10: (1 comment) http://gerrit.ovirt.org/#/c/28579/10/packaging/setup/plugins/ovirt-engine-remove/ovirt-engine/config/misc.py File packaging/setup/plugins/ovirt-engine-remove/ovirt-engine/config/misc.py: Line 87: 'ca_pki', Line 88: 'iso_domain', Line 89: 'ca_config', Line 90: 'ssl', Line 91: 'versionlock', > adding a prefix to group will break compatibility with existing uninstall . no... I mean that we have the information within the uninstall file. remember? our task is to put as much information within uninstall so that the uninstall will be as stupid as we can have. as uninstall will be modified after upgrade, I think the new groups will be available there anyway... so we can modify names. also, if there is somekind of a problem we can have temporary mapping between old and new. anything that will require update of both setup and remove on regular basis. Line 92: ] Line 93: ) Line 94: -- To view, visit http://gerrit.ovirt.org/28579 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I26017770262e313ad38ddfa96baeaea144c86e5f Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
