Tomas Jelinek has posted comments on this change. Change subject: webadmin: No red warning when export template that already exists. ......................................................................
Patch Set 2: (1 inline comment) I wanted to touch only the logic which was actually buggy, but you are right. I will extract also the rest of the export logic, so please do not merge this patch yet. .................................................... File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateListModel.java Line 261: model.StopProgress(); Because I need to stop the progress animation when the logic of creating the window is done. There are several situations when it can be done, and I can not really unify them, because it has to be stopped in every case except the last else statement (in that case the computation continues and the stopProgress is called in PostShowWarningOnExistingVms. -- To view, visit http://gerrit.ovirt.org/5228 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id96054d4c464ae0373cfa3c2487d8021e2971568 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
