Gilad Chaplik has posted comments on this change. Change subject: webadmin: No red warning when export template that already exists. ......................................................................
Patch Set 2: (1 inline comment) you are doing a great thing creating a base class to vm/template list, but why not moving the entire export code to the base class? .................................................... File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateListModel.java Line 261: model.StopProgress(); why there are so many calls to stopProgress? -- To view, visit http://gerrit.ovirt.org/5228 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id96054d4c464ae0373cfa3c2487d8021e2971568 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
