Tomas Jelinek has uploaded a new change for review. Change subject: webadmin: No red warning when export template that already exists. ......................................................................
webadmin: No red warning when export template that already exists. Template -> select one -> Export If this template has already been exported, the popup shuld contain a red message which warns that this has already been exported. The problem was in TemplateListModel.showWarningOnExistingTemplates method which used synchronous queries to retrive storage_pool and templates on the export domain which does not work on the GWT envirotnment. Fixed by extracting and generalizing the correct logic from VmListModel to a common parent VmBaseListModel and calling this common logic. Change-Id: Id96054d4c464ae0373cfa3c2487d8021e2971568 Signed-off-by: Tomas Jelinek <tjeli...@redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateListModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/VmBaseListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java 3 files changed, 148 insertions(+), 120 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/28/5228/1 -- To view, visit http://gerrit.ovirt.org/5228 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id96054d4c464ae0373cfa3c2487d8021e2971568 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
