Oved Ourfali has posted comments on this change. Change subject: core: Improve Dynamic Query SQL generator ......................................................................
Patch Set 12: (1 comment) http://gerrit.ovirt.org/#/c/28135/12/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/SearchQueryTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/SearchQueryTest.java: Line 66: final StoragePoolDAO storagePoolDAO = Mockito.mock(StoragePoolDAO.class); Line 67: final GlusterVolumeDao glusterVolumeDao = Mockito.mock(GlusterVolumeDao.class); Line 68: final NetworkViewDao networkViewDao = Mockito.mock(NetworkViewDao.class); Line 69: final DbEngineDialect dbEngineDialect = Mockito.mock(DbEngineDialect.class); Line 70: final DbFacade facadeMock = new DbFacade() { build is broken in this file and this line. please fix that. Line 71: @Override Line 72: public DiskDao getDiskDao() { Line 73: return diskDao; Line 74: } -- To view, visit http://gerrit.ovirt.org/28135 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I862873171c6753f8c8863c10c336e981e39dc8cb Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
