Yair Zaslavsky has posted comments on this change. Change subject: core: Improve Dynamic Query SQL generator ......................................................................
Patch Set 12: (3 comments) http://gerrit.ovirt.org/#/c/28135/12/backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/StorageDomainFieldAutoCompleter.java File backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/StorageDomainFieldAutoCompleter.java: Line 43: Line 44: // building the ColumnName Dict Line 45: columnNameDict.put(NAME, "storage_name"); Line 46: columnNameDict.put(STATUS, "storage_domain_shared_status"); Line 47: columnNameDict.put(DATACENTER, "storage_pool_name::text"); why did you specify here ::text? due to casting? Line 48: columnNameDict.put(TYPE, "storage_type"); Line 49: columnNameDict.put(SIZE, "available_disk_size"); Line 50: columnNameDict.put(USED, "used_disk_size"); Line 51: columnNameDict.put(COMMITTED, "commited_disk_size"); http://gerrit.ovirt.org/#/c/28135/12/backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxChecker.java File backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxChecker.java: Line 860: Line 861: // Add special handling (not deleted) to event searches Line 862: if (searchObjStr.equalsIgnoreCase("EVENT")) { Line 863: whereBuilder.add("not deleted"); Line 864: } > not sure I understand this special treatment. Oved, we keep in the table of events events that are also deleted, but UI should not see them. Liran, will introducing a view just for the "non deleted events" simplify things? Line 865: Line 866: // adding WHERE if required and All implicit AND Line 867: StringBuilder wherePhrase = new StringBuilder(); Line 868: if (whereBuilder.size() > 0) { http://gerrit.ovirt.org/#/c/28135/12/backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxContainer.java File backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxContainer.java: Line 19: private int privateMaxCount; Line 20: private long searchFrom = 0; Line 21: private boolean caseSensitive=true; Line 22: Line 23: public boolean isTags() { > Please rename to something more meaningful +1 - but isSearchUsingTags :) Line 24: return mOrigText.contains("tag") Line 25: || (getSearchObjectStr() != null && (getSearchObjectStr().equals(SearchObjects.VDC_USER_OBJ_NAME))) Line 26: || (getCrossRefObjList().contains(SearchObjects.VDC_STORAGE_DOMAIN_OBJ_NAME) && (getSearchObjectStr() == null || !getSearchObjectStr().equals(SearchObjects.VDS_OBJ_NAME))); Line 27: } -- To view, visit http://gerrit.ovirt.org/28135 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I862873171c6753f8c8863c10c336e981e39dc8cb Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
