Eli Mesika has posted comments on this change. Change subject: core: Improve Dynamic Query SQL generator ......................................................................
Patch Set 12: (2 comments) http://gerrit.ovirt.org/#/c/28135/12/backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxChecker.java File backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxChecker.java: Line 1111: Line 1112: String tableName; Line 1113: Line 1114: // We will take the table with tags for all subtables Line 1115: // TODO: Optimize this what about this TODO, is should be done or omitted from the final patch Line 1116: if (conditionType == ConditionType.ConditionwithSpesificObj) { Line 1117: tableName = mSearchObjectAC.getRelatedTableName(objName, true); Line 1118: } else { Line 1119: tableName = mSearchObjectAC.getRelatedTableName(objName, fieldName); http://gerrit.ovirt.org/#/c/28135/12/backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxContainer.java File backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxContainer.java: Line 19: private int privateMaxCount; Line 20: private long searchFrom = 0; Line 21: private boolean caseSensitive=true; Line 22: Line 23: public boolean isTags() { Please rename to something more meaningful isSearchUsesTags or any equivalent Line 24: return mOrigText.contains("tag") Line 25: || (getSearchObjectStr() != null && (getSearchObjectStr().equals(SearchObjects.VDC_USER_OBJ_NAME))) Line 26: || (getCrossRefObjList().contains(SearchObjects.VDC_STORAGE_DOMAIN_OBJ_NAME) && (getSearchObjectStr() == null || !getSearchObjectStr().equals(SearchObjects.VDS_OBJ_NAME))); Line 27: } -- To view, visit http://gerrit.ovirt.org/28135 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I862873171c6753f8c8863c10c336e981e39dc8cb Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
