Alon Bar-Lev has posted comments on this change. Change subject: dwh: Split of engine-setup-plugin ......................................................................
Patch Set 8: (3 comments) http://gerrit.ovirt.org/#/c/28242/8/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/core/check_etl.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/core/check_etl.py: Line 75 Line 76 Line 77 Line 78 Line 79 more correctly... minMajor, minMinor, minPatchLevel = self._parseVersionString( result[0]['option_value'] ) Line 83: name='MinimalETLVersion', Line 84: ), Line 85: ownConnection=True, Line 86: ) Line 87: if len(result) == 0: this should be: if result: Line 88: raise RuntimeError( Line 89: _('Cannot find MinimalETLVersion in vdc_options') Line 90: ) Line 91: r = result[0] Line 88: raise RuntimeError( Line 89: _('Cannot find MinimalETLVersion in vdc_options') Line 90: ) Line 91: r = result[0] Line 92: minimalVersion = r['option_value'] this should be: minimalVersion = result[0]['option_value'] Line 93: Line 94: minMajor, minMinor, minPatchLevel = self._parseVersionString( Line 95: minimalVersion Line 96: ) -- To view, visit http://gerrit.ovirt.org/28242 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1e53dd09940697fe6ef73ed63ef4369e73b02c42 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
