Simone Tiraboschi has posted comments on this change. Change subject: dwh: Split of engine-setup-plugin ......................................................................
Patch Set 7: (1 comment) http://gerrit.ovirt.org/#/c/28242/7/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/core/check_etl.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/core/check_etl.py: Line 70 Line 71 Line 72 Line 73 Line 74 > Why not move vdcoption.py to engine_common and use it? I briefly discussed it with Alon splitting engine constants into different plugins. The idea was to limit low level VDC options access to the engine plugin cause they are stored in the engine DB. The values about the location of the websocket proxy and the reports URL can be set to their default values (localhost) by the engine plugin; we need to override them just when we split the installation onto multiple host asking to the user to use engine-config on the engine host. DWH just needs to read this values (getVdcOption) and is probably better, in the future, to have it via API without accessing the DB (either via VDC class helper or directly as in this patch). So we don't need direct VDC access from other ovirt options. -- To view, visit http://gerrit.ovirt.org/28242 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1e53dd09940697fe6ef73ed63ef4369e73b02c42 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
