Simone Tiraboschi has posted comments on this change. Change subject: dwh: Split of engine-setup-plugin ......................................................................
Patch Set 7: (3 comments) http://gerrit.ovirt.org/#/c/28242/7/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/core/check_etl.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/core/check_etl.py: Line 82: name='MinimalETLVersion', Line 83: ), Line 84: ownConnection=True, Line 85: ) Line 86: if len(result) == 0: > you can ask if not result Who to ask and what to ask for? Is the user really aware of it? Line 87: raise RuntimeError( Line 88: _('Cannot find MinimalETLVersion in vdc_options') Line 89: ) Line 90: else: Line 86: if len(result) == 0: Line 87: raise RuntimeError( Line 88: _('Cannot find MinimalETLVersion in vdc_options') Line 89: ) Line 90: else: > no need else within exceptional pattern Done Line 91: r = result[0] Line 92: minimalVersion = r['option_value'] Line 93: self.logger.debug( Line 94: 'vdc_options MinimalETLVersion: %s)\n', Line 92: minimalVersion = r['option_value'] Line 93: self.logger.debug( Line 94: 'vdc_options MinimalETLVersion: %s)\n', Line 95: minimalVersion Line 96: ) > you do not need to debug this as the statement will Done Line 97: Line 98: minMajor, minMinor, minPatchLevel = self._parseVersionString( Line 99: minimalVersion Line 100: ) -- To view, visit http://gerrit.ovirt.org/28242 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1e53dd09940697fe6ef73ed63ef4369e73b02c42 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
