mooli tayer has posted comments on this change. Change subject: engine_page: remove dep. from ovirt_config_setup.engine ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/28232/1/src/engine_page.py File src/engine_page.py: Line 486: Line 487: if not os.path.exists(config.VDSM_CONFIG): Line 488: self.create_vdsm_conf() Line 489: self.logger.info("Agent configuration files created.") Line 490: ovirt_store_config(config.VDSM_CONFIG) > Config().persist(config.VDSM_CONFIG) aren't you calling store config twice? - Once here and once inside create_vdsm_conf Line 491: Line 492: self.server = server Line 493: self.port = port Line 494: -- To view, visit http://gerrit.ovirt.org/28232 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia04f6fb1d3822828f543cfa4472d9e224162b5ff Gerrit-PatchSet: 1 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsl...@redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabi...@fedoraproject.org> Gerrit-Reviewer: Ryan Barry <rba...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
