Ryan Barry has posted comments on this change. Change subject: engine_page: remove dep. from ovirt_config_setup.engine ......................................................................
Patch Set 1: Code-Review-1 (3 comments) http://gerrit.ovirt.org/#/c/28232/1/src/engine_page.py File src/engine_page.py: Line 30: Line 31: from ovirt.node import plugins, valid, ui, utils, log Line 32: from ovirt.node.config.defaults import NodeConfigFileSection, SSH, Management Line 33: from ovirt.node.plugins import Changeset Line 34: from ovirtnode.ovirtfunctions import ovirt_store_config Please use: from ovirt.node.utils.fs import File Instead of the old codebase (ovirtnode.*) Line 35: Line 36: from vdsm import vdscli Line 37: Line 38: """ Line 486: Line 487: if not os.path.exists(config.VDSM_CONFIG): Line 488: self.create_vdsm_conf() Line 489: self.logger.info("Agent configuration files created.") Line 490: ovirt_store_config(config.VDSM_CONFIG) FIle(config.VDSM_CONFIG).persist() Line 491: Line 492: self.server = server Line 493: self.port = port Line 494: Line 510: Line 511: with open(config.VDSM_CONFIG, 'w') as configfile: Line 512: cfg.write(configfile) Line 513: Line 514: ovirt_store_config(config.VDSM_CONFIG) File(config.VDSM_CONFIG).persist() Line 515: Line 516: def commit(self): Line 517: self.logger.info("Connecting to VDSM server") Line 518: -- To view, visit http://gerrit.ovirt.org/28232 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia04f6fb1d3822828f543cfa4472d9e224162b5ff Gerrit-PatchSet: 1 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsl...@redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabi...@fedoraproject.org> Gerrit-Reviewer: Ryan Barry <rba...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
