Fabian Deutsch has posted comments on this change. Change subject: engine_page: remove dep. from ovirt_config_setup.engine ......................................................................
Patch Set 2: Code-Review-1 (2 comments) Please change the passing of the exceptions, and just take a look if you'd rather like to use exceptions in the other case (instead of return values). http://gerrit.ovirt.org/#/c/28232/2/src/engine_page.py File src/engine_page.py: Line 67: with open(conf_file, 'w+') as configfile: Line 68: cfg.write(configfile) Line 69: except ConfigParser.Error as e: Line 70: LOGGER.debug("Cannot write into file!", exc_info=True) Line 71: raise e Youshould just use raise here to pass the whole stack to the caller Line 72: Line 73: return True Line 74: Line 75: Line 531: # menus are run after installation Line 532: self.logger.info("Stopping vdsm-reg service") Line 533: deployUtil._logExec([constants.EXT_SERVICE, 'vdsm-reg', 'stop']) Line 534: Line 535: ret = update_conf( To avoid this ret = ladders ret = update… if ret: update… if ret: update… You can also use exceptions, then you can just use: update… update… update… And catch the exception once. Line 536: config.VDSM_REG_CONFIG, Line 537: "vars", Line 538: "vdc_host_name", Line 539: cfg["server"] -- To view, visit http://gerrit.ovirt.org/28232 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia04f6fb1d3822828f543cfa4472d9e224162b5ff Gerrit-PatchSet: 2 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsl...@redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabi...@fedoraproject.org> Gerrit-Reviewer: Ryan Barry <rba...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
