Michael Kublin has posted comments on this change. Change subject: core: initial ReconstructMasterDomain refactoring ......................................................................
Patch Set 4: I would prefer that you didn't submit this Two xml rpc calls , two tries to acquire a lock and all these inside one transaction, the rule says : try keep transaction a shorten as possible, here is not a case -- To view, visit http://gerrit.ovirt.org/5329 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I79fdcf9870a003fc79e273a6fc89351e3dad5b5c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
