Maor Lipchuk has posted comments on this change.
Change subject: core: initial ReconstructMasterDomain refactoring
......................................................................
Patch Set 2: (8 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ReconstructMasterDomainCommand.java
Line 93: // Pause the timers for the domain error handling
Please use the formatter here
Line 98: Boolean commandSucceeded = stopSpm();
Suggestion: You can simply write in one command line:
Boolean commandSucceeded = stopSpm() &&
runVdsCommand(VDSCommandType.DisconnectStoragePool,...)
by that you can reduce one line code.
BTW You can also use it directly in the condition you use later with the
commandSucceeded and by that the code will be even shorter, but that is if you
think it will be readable enough
Line 100: commandSucceeded = commandSucceeded && runVdsCommand(
Please use formatter here
Line 110: List<storage_pool_iso_map> domains =
getStoragePoolIsoMapDAO()
Please use formatter here
Line 118: throw new VdcBLLException(
Please use formatter here
Line 125: return runVdsCommand(VDSCommandType.ReconstructMaster,
Please use formatter here
Line 138: TransactionScopeOption.RequiresNew, new
ReconstructTransaction()
Please use formatter here
Line 143: if (!_isLastMaster && commandSucceeded) {
Please use formatter for the rest of the code here, thanks
--
To view, visit http://gerrit.ovirt.org/5329
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I79fdcf9870a003fc79e273a6fc89351e3dad5b5c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
