Alona Kaplan has posted comments on this change. Change subject: engine: errors in audit log- VDS_SET_NONOPERATIONAL_IFACE_DOWN ......................................................................
Patch Set 3: (3 comments) http://gerrit.ovirt.org/#/c/27720/3/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/NetworkMonitoringHelper.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/NetworkMonitoringHelper.java: Line 25: * which are required by these NICs. Line 26: */ Line 27: public static Map<String, Set<String>> determineProblematicNics(List<VdsNetworkInterface> interfaces, Line 28: List<Network> clusterNetworks) { Line 29: Map<String, Set<String>> brokenNicsToNetworks = new HashMap<String, Set<String>>(); > should be: new HashMap<>() Done Line 30: Line 31: Map<String, Network> networksByName = NetworkUtils.networksByName(clusterNetworks); Line 32: Line 33: for (VdsNetworkInterface iface : interfaces) { http://gerrit.ovirt.org/#/c/27720/3/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java: Line 771: constructNicsWithNetworksString(problematicNicsWithNetworks); Line 772: Line 773: _vds.setNonOperationalReason(NonOperationalReason.NETWORK_INTERFACE_IS_DOWN); Line 774: _vdsManager.setStatus(VDSStatus.NonOperational, _vds); Line 775: log.infoFormat("Host '%s' moved to Non-Operational state because interface/s which are down are needed by required network/s in the current cluster: '%s'", > should be {0} and {1} instead of %s Done Line 776: _vds.getName(), Line 777: problematicNicsWithNetworksString); Line 778: Line 779: AuditLogableBase logable = new AuditLogableBase(_vds.getId()); Line 793: } Line 794: Line 795: private String constructNicsWithNetworksString(Map<String, Set<String>> nicsWithNetworks) { Line 796: List<String> reportedNics = new ArrayList<>(nicsWithNetworks.size()); Line 797: for (Entry<String, Set<String>> nicToNetworks : nicsWithNetworks.entrySet()) { > please reformat this method using the code formatter. Done Line 798: reportedNics.add(String.format("%s (%s)", Line 799: nicToNetworks.getKey(), Line 800: StringUtils.join(nicToNetworks.getValue(), ", "))); Line 801: } -- To view, visit http://gerrit.ovirt.org/27720 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9dfa5396c7622b5e689ee3e648fcccd0e75ed834 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
