Yevgeny Zaspitsky has posted comments on this change. Change subject: engine: errors in audit log- VDS_SET_NONOPERATIONAL_IFACE_DOWN ......................................................................
Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/27720/2/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/NetworkMonitoringHelper.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/NetworkMonitoringHelper.java: Line 72: InterfaceStatus can status be NONE? do we distinguish between DOWN and NONE here? Line 74: Line 75: String baseIfaceName = iface.getBaseInterface(); Line 76: for (VdsNetworkInterface tmpIface : interfaces) { Line 77: if (tmpIface.getName().equals(baseIfaceName)) { Line 78: return tmpIface.getStatistics().getStatus() != InterfaceStatus.UP; same Line 79: } Line 80: } Line 81: Line 82: // not suppose to get here -- To view, visit http://gerrit.ovirt.org/27720 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9dfa5396c7622b5e689ee3e648fcccd0e75ed834 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
