Alona Kaplan has posted comments on this change. Change subject: engine: errors in audit log- VDS_SET_NONOPERATIONAL_IFACE_DOWN ......................................................................
Patch Set 2: (6 comments) http://gerrit.ovirt.org/#/c/27720/2//COMMIT_MSG Commit Message: Line 18: Line 19: This patch fixes these errors and also slightly changes the format of the Line 20: error message. Line 21: Line 22: Since the bond status can be determined from the bond itself and shouldn't > Does bond status reported since 3.0 ? yes. Line 23: be calculated from the slaves status and most of the bugs were part of this Line 24: logic, this patch removes it. Line 25: Line 26: Change-Id: I9dfa5396c7622b5e689ee3e648fcccd0e75ed834 http://gerrit.ovirt.org/#/c/27720/2/backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties File backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties: Line 463: UPGRADE_STORAGE_POOL_ENCOUNTERED_PROBLEMS=Data Center ${StoragePoolName} has encountered problems during upgrade process. Line 464: USER_UPDATE_STORAGE_POOL_FAILED=Failed to update Data Center ${StoragePoolName}. (User: ${UserName}) Line 465: VDS_SET_NONOPERATIONAL_NETWORK=Host ${VdsName} does not comply with the cluster ${VdsGroupName} networks, the following networks are missing on host: '${Networks}' Line 466: VDS_NETWORKS_OUT_OF_SYNC=Host ${VdsName}'s following network(s) are not synchronized with their Logical Network configuration: ${Networks}. Line 467: VDS_SET_NONOPERATIONAL_IFACE_DOWN=Host ${VdsName} moved to Non-Operational state because interface/s which are down are needed by required network/s in the current cluster: '${NicsWithNetworks}'. > i'm not a great fan of "interface/s" and "network/s" Done Line 468: BRIDGED_NETWORK_OVER_MULTIPLE_INTERFACES=Bridged network ${NetworkName} is attached to multiple interfaces: ${Interfaces} on Host ${VdsName}. Line 469: NETWORK_WITHOUT_INTERFACES=Network ${NetworkName} is not attached to any interface on host ${VdsName}. Line 470: VNIC_PROFILE_UNSUPPORTED_FEATURES=VM ${VmName} has network interface ${NicName} which is using profile ${VnicProfile} with unsupported feature(s) '${UnsupportedFeatures}' by VM cluster ${VdsGroupName} (version ${CompatibilityVersion}). Line 471: ADD_NETWORK_BY_LABEL_FAILED=Network ${Network} cannot be configured using the label ${Label} in data-center ${StoragePoolName} on the following hosts: ${HostNames}. http://gerrit.ovirt.org/#/c/27720/2/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/NetworkMonitoringHelper.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/NetworkMonitoringHelper.java: Line 25: * which are required by these NICs. Line 26: */ Line 27: public static Map<String, Set<String>> determineProblematicNics(List<VdsNetworkInterface> interfaces, Line 28: List<Network> clusterNetworks) { Line 29: Map<String, Set<String>> brokenNicsToNetworks = new HashMap<String, Set<String>>(); > you can omit the type declaration on the right side. I get an eclipse warning if I omit it... Line 30: Line 31: Map<String, Network> networksByName = NetworkUtils.networksByName(clusterNetworks); Line 32: Line 33: for (VdsNetworkInterface iface : interfaces) { Line 37: Line 38: if (networks == null) { Line 39: networks = new HashSet<String>(); Line 40: brokenNicsToNetworks.put(baseNicName, networks); Line 41: } > please add a space line :) Done Line 42: networks.add(iface.getNetworkName()); Line 43: } Line 44: } Line 45: http://gerrit.ovirt.org/#/c/27720/2/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java: Line 769: try { Line 770: String problematicNicsWithNetworksString = constructNicsWithNetworksString(problematicNicsWithNetworks); Line 771: Line 772: String message = Line 773: String.format( > although not 100% related to this patch, but since you're already modifying Done Line 774: "Host '%s' moved to Non-Operational state because interface/s which are down are needed by required network/s in the current cluster: '%s'", Line 775: _vds.getName(), Line 776: problematicNicsWithNetworksString); Line 777: Line 810: Line 811: String nicsWithNetworksString = nicsWithNetworksBuilder.toString(); Line 812: Line 813: return nicsWithNetworksBuilder.delete(nicsWithNetworksString.length() - 2, nicsWithNetworksString.length()) Line 814: .toString(); > the following will get the same result with more readability IMO: Done Line 815: } Line 816: Line 817: private void reportNicStatusChanges() { Line 818: List<VdsNetworkInterface> interfaces = _vds.getInterfaces(); -- To view, visit http://gerrit.ovirt.org/27720 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9dfa5396c7622b5e689ee3e648fcccd0e75ed834 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
