Maor Lipchuk has posted comments on this change. Change subject: core : further cleanup of StorageHelperDirector ......................................................................
Patch Set 6: (2 inline comments) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperDirector.java Line 36: // eat it Please also add an error log here instead the "eat it" comment as part of the cleanup Line 39: * if action type not exist - operation valid Suggestion: You can replace the java doc here to simple comment with double dash. it just takes more space that way -- To view, visit http://gerrit.ovirt.org/5180 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie667122156fce0c38312df7e08c22c599b59a900 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
