Allon Mureinik has posted comments on this change. Change subject: core: cleanup of StorageHelperDirector ......................................................................
Patch Set 5: Looks good to me, but someone else must approve (1 inline comment) basically looks good, see inline question/suggestion .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperDirector.java Line 44: IStorageHelper currentHelper = (IStorageHelper) tempVar; Double check this, but AFAIK Constructor.newInstance() can't return null - it throws an exception if it fails, so the if (currentHelper != null) may be redundant. -- To view, visit http://gerrit.ovirt.org/5180 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie667122156fce0c38312df7e08c22c599b59a900 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
