Michael Kublin has posted comments on this change.
Change subject: core: cleanup of StorageHelperDirector
......................................................................
Patch Set 4: (5 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperDirector.java
Line 11: private static StorageHelperDirector _instance = new
StorageHelperDirector();
Replace to EnumMap
Line 24: try {
Remove using of EnumCompat.GetNames, these is a leftovers after C#
Line 29: "org.ovirt.engine.core.bll.storage",
Make a constant, private static final String
Line 31: "StorageHelper"));
Same here, const
Line 41: IStorageHelper currentHelper = (IStorageHelper)
((tempVar instanceof IStorageHelper) ? tempVar
no need for check , if ! (tempVar instanceof IStorageHelper) it is a bug, also
leftovers from C#, should be removed during clean up
--
To view, visit http://gerrit.ovirt.org/5180
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie667122156fce0c38312df7e08c22c599b59a900
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
