Gilad Chaplik has posted comments on this change. Change subject: core: ignore NUMA nodeset when empty ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/27799/2/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java: Line 211: else { Line 212: if (!vmNumaNodePinInfo.isEmpty()) { Line 213: createNumaTune.put(VdsProperties.NUMA_TUNE_NODESET, Line 214: NumaUtils.buildStringFromListForNuma(vmNumaNodePinInfo)); Line 215: } > can you please explain what should be added and what can go wrong with this this patch only solves a bug. lets merge it. Line 216: } Line 217: createInfo.put(VdsProperties.NUMA_TUNE, createNumaTune); Line 218: if (StringUtils.isEmpty(vm.getCpuPinning())) { Line 219: Map<String, Object> cpuPinDict = addCpuPinningForNumaSetting(vmNumaNodes, totalVdsNumaNodes); -- To view, visit http://gerrit.ovirt.org/27799 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff17fd54580f4a451bbb2aabe31f7629a2d0824b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Xiaolei Shi <xiao-lei....@hp.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
