Gilad Chaplik has uploaded a new change for review. Change subject: core: ignore NUMA nodeset when empty ......................................................................
core: ignore NUMA nodeset when empty Change-Id: Iff17fd54580f4a451bbb2aabe31f7629a2d0824b Bug-Url: https://bugzilla.redhat.com/1098539 Signed-off-by: Gilad Chaplik <gchap...@redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java 1 file changed, 6 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/99/27799/1 diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java index 52f874c..07fe140 100644 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java +++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java @@ -202,11 +202,13 @@ else { useAllVdsNodesMem = true; } - if (useAllVdsNodesMem) { - createNumaTune.put(VdsProperties.NUMA_TUNE_NODESET, NumaUtils.buildStringFromListForNuma(totalVdsNumaNodesIndexes)); + if (useAllVdsNodesMem && !totalVdsNumaNodesIndexes.isEmpty()) { + createNumaTune.put(VdsProperties.NUMA_TUNE_NODESET, + NumaUtils.buildStringFromListForNuma(totalVdsNumaNodesIndexes)); } - else { - createNumaTune.put(VdsProperties.NUMA_TUNE_NODESET, NumaUtils.buildStringFromListForNuma(vmNumaNodePinInfo)); + else if (!vmNumaNodePinInfo.isEmpty()) { + createNumaTune.put(VdsProperties.NUMA_TUNE_NODESET, + NumaUtils.buildStringFromListForNuma(vmNumaNodePinInfo)); } createInfo.put(VdsProperties.NUMA_TUNE, createNumaTune); if (StringUtils.isEmpty(vm.getCpuPinning())) { -- To view, visit http://gerrit.ovirt.org/27799 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iff17fd54580f4a451bbb2aabe31f7629a2d0824b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
