Arik Hadas has posted comments on this change. Change subject: core: ignore NUMA nodeset when empty ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/27799/1/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java: Line 209: vmNumaNodePinInfo there is a change in the behavior: if useAllVdsNodesMem is true because the numa list is empty for one of the nodes, and the totalVdsNumaNodesIndexes is empty + vmNumaNodePinInfo is not empty (I'm not sure if that's possible though), then we'll execute #210 and before this change we didn't execute #206 or #210, are you sure that change is ok? -- To view, visit http://gerrit.ovirt.org/27799 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff17fd54580f4a451bbb2aabe31f7629a2d0824b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
