Maor Lipchuk has posted comments on this change. Change subject: core: replace vm id with number of vms in views. ......................................................................
Patch Set 1: 1. This patch was verified, does not break scenarios and pass the tests, please verify before jump into conclusions. 2. Don't remember that we agreed that dynamic calculation is bad what is the reason not using it? what do you think is a better alternative? 3.Agree that the attribute in the disk should be deleted, was forgotten and I will send a patch with this fixes If some test does not pass, or some scenario is not working please specify which one, if not, I think -2 is wrong here since the patch does not break nothing. -- To view, visit http://gerrit.ovirt.org/5216 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id306d8322245780ea200c10f9e96254cddf3bc76 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
