Allon Mureinik has posted comments on this change. Change subject: core: replace vm id with number of vms in views. ......................................................................
Patch Set 1: (9 inline comments) see inline .................................................... File backend/manager/dbscripts/create_views.sql Line 69: LEFT OUTER JOIN base_disks ON images.image_group_id = base_disks.disk_id device_id in vm_device is not null. replace count(device_id) with count(*), and allow the database to decide how it does the count function. Line 232: LEFT JOIN You use the vm_static_device query in multiple places - extract it to its own view. .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DiskImage.java Line 14: shouldn't you add number_of_vms? Line 81: VmEntityType vmEntityType, why not int? .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Disk.java Line 21: private VmEntityType vmEntityType; why Integer and not int? Line 118: here too Line 122: and here too. .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/LunDisk.java Line 24: VmEntityType vmEntityType, why not int? .................................................... File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java Line 351: Why is this change part of this patch? -- To view, visit http://gerrit.ovirt.org/5216 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id306d8322245780ea200c10f9e96254cddf3bc76 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
