Allon Mureinik has posted comments on this change. Change subject: core: replace vm id with number of vms in views. ......................................................................
Patch Set 1: (6 inline comments) .................................................... File backend/manager/dbscripts/create_views.sql Line 69: LEFT OUTER JOIN base_disks ON images.image_group_id = base_disks.disk_id agreed count(device_id) and count(*) will have the same result. using count(*) will allow the database some optiomizations that count(device_id) doesn't. Line 232: LEFT JOIN disagree, but it's a matter of taste. .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DiskImage.java Line 14: You just added the number_of_vms fields in this patch, no? we obviously have a missunderstanding. Line 81: VmEntityType vmEntityType, same answer :-) .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Disk.java Line 21: private VmEntityType vmEntityType; I think you should change it. In the database, there is no way this can be null (you use coalesce to ensure that) - the BE should reflect that. .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/LunDisk.java Line 24: VmEntityType vmEntityType, same answer :-) -- To view, visit http://gerrit.ovirt.org/5216 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id306d8322245780ea200c10f9e96254cddf3bc76 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
