Alon Bar-Lev has posted comments on this change. Change subject: setup: Write the answer file if file path is valid ......................................................................
Patch Set 3: (3 comments) http://gerrit.ovirt.org/#/c/27731/3/packaging/setup/plugins/ovirt-engine-common/base/core/answerfile.py File packaging/setup/plugins/ovirt-engine-common/base/core/answerfile.py: Line 121: error=e, Line 122: ) Line 123: ) Line 124: self.logger.debug( Line 125: 'Exception while writing to answer file: %s' % answer, this should be as parameter to reduce time. Line 126: exc_info=True Line 127: ) Line 128: Line 122: ) Line 123: ) Line 124: self.logger.debug( Line 125: 'Exception while writing to answer file: %s' % answer, Line 126: exc_info=True comma is missing... Line 127: ) Line 128: Line 123: ) Line 124: self.logger.debug( Line 125: 'Exception while writing to answer file: %s' % answer, Line 126: exc_info=True Line 127: ) so it should be: self.logger.debug( 'Exception while writing to answer file: %s', answer, exc_info=True, ) Line 128: -- To view, visit http://gerrit.ovirt.org/27731 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8c595449e631f0bdb9524d74bdc3d9b1a256439f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
