Shubhendu Tripathi has posted comments on this change. Change subject: setup: Write the answer file if file path is valid ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/27731/1/packaging/setup/plugins/ovirt-engine-common/base/core/answerfile.py File packaging/setup/plugins/ovirt-engine-common/base/core/answerfile.py: Line 109: else v, Line 110: ) Line 111: ) Line 112: except IOError as e: Line 113: self.logger.warning(e) > this is going to user, so we need to be much nicer. done Line 114: Line 115: -- To view, visit http://gerrit.ovirt.org/27731 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8c595449e631f0bdb9524d74bdc3d9b1a256439f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches