Shubhendu Tripathi has posted comments on this change. Change subject: setup: Write the answer file if file path is valid ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/27731/2/packaging/setup/plugins/ovirt-engine-common/base/core/answerfile.py File packaging/setup/plugins/ovirt-engine-common/base/core/answerfile.py: Line 112: except IOError as e: Line 113: self.logger.warning('Cannot write to answer file {file}' \ Line 114: ', error: {error}'.format( Line 115: file=answer, Line 116: error=e) > please keep indentation per this project style, do not draw code, single in sure. will do this. Line 117: ) Line 118: Line 119: -- To view, visit http://gerrit.ovirt.org/27731 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8c595449e631f0bdb9524d74bdc3d9b1a256439f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
