Alon Bar-Lev has posted comments on this change.
Change subject: aaa: Remove dependency at builtin on Common config
......................................................................
Patch Set 7:
if you do not find any way to avoid singletones within this set of
configuration, and you have singleton... and you have even sinle singleton...
no reason not to use it all over...
I thought that of:
202 + ConfigValues.LdapServers,
203 + ConfigValues.LDAPServerPort,
204 + ConfigValues.AdUserName,
205 + ConfigValues.AdUserPassword,
206 + ConfigValues.LDAPSecurityAuthentication,
207 + ConfigValues.AuthenticationMethod,
208 + ConfigValues.LDAPProviderTypes,
209 + ConfigValues.LDAPQueryTimeout,
210 + ConfigValues.DomainName,
211 + ConfigValues.SASL_QOP,
212 + ConfigValues.LDAPConnectTimeout,
213 + ConfigValues.MaxLDAPQueryPartsNumber,
214 + ConfigValues.LDAPOperationTimeout,
215 + ConfigValues.LdapQueryPageSize);
There should be no variable that requires access to config without having at
least the domain configuration.
--
To view, visit http://gerrit.ovirt.org/27607
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1384a99f73ab605b61bce8dcdfd63e222b0001fa
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
