Alon Bar-Lev has posted comments on this change. Change subject: aaa: Remove dependency at builtin on Common config ......................................................................
Patch Set 7: (2 comments) ok... so if you keep the singleton you can drop 95% of this code. hybrid solution is more harm than good. http://gerrit.ovirt.org/#/c/27607/7/backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/Utils.java File backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/Utils.java: Line 13: defaults.load(Utils.class.getResourceAsStream("/builtin/defaults.properties")); Line 14: for (Map.Entry<Object, Object> entry : defaults.entrySet()) { Line 15: putIfAbsent(conf, (String) entry.getKey(), (String) entry.getValue()); Line 16: } Line 17: - Line 18: } catch (IOException e) { Line 19: throw new RuntimeException(e); Line 20: } Line 21: Line 17: Line 18: } catch (IOException e) { Line 19: throw new RuntimeException(e); Line 20: } Line 21: - Line 22: } Line 23: Line 24: } Line 25: -- To view, visit http://gerrit.ovirt.org/27607 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1384a99f73ab605b61bce8dcdfd63e222b0001fa Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
