Yair Zaslavsky has posted comments on this change. Change subject: aaa: Remove dependency at builtin on Common config ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/27607/5/backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/Utils.java File backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/Utils.java: Line 19: putIfAbsent(conf, "LDAPConnectTimeout", "30"); Line 20: putIfAbsent(conf, "MaxLDAPQueryPartsNumber", "100"); Line 21: putIfAbsent(conf, "LDAPOperationTimeout", "30"); Line 22: putIfAbsent(conf, "LdapQueryPageSize", "1000"); Line 23: } > hmmmm.... won't it better to have properties as resource in the exact forma I really don't see such a great benefit to it, but I'll change. No problem. Line 24: Line 25: } Line 26: Line 27: private static void putIfAbsent(Properties props, String key, String value) { -- To view, visit http://gerrit.ovirt.org/27607 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1384a99f73ab605b61bce8dcdfd63e222b0001fa Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
