Gilad Chaplik has posted comments on this change. Change subject: db: Numa support database implementation ......................................................................
Patch Set 23: Code-Review+1 (3 comments) please add DAO tests. http://gerrit.ovirt.org/#/c/26996/23/packaging/dbscripts/create_views.sql File packaging/dbscripts/create_views.sql: Line 1714: run_in_vds_numa_node.usage_cpu_percent as run_in_vds_numa_node_usage_cpu_percent, Line 1715: run_in_vds_numa_node.distance as run_in_vds_numa_node_distance Line 1716: FROM vm_vds_numa_node_map Line 1717: LEFT OUTER JOIN numa_node as vm_numa_node on vm_vds_numa_node_map.vm_numa_node_id = vm_numa_node.numa_node_id Line 1718: LEFT OUTER JOIN numa_node as run_in_vds_numa_node on vm_vds_numa_node_map.vds_numa_node_id = run_in_vds_numa_node.numa_node_id; > Have add numa fields in current vds and vms views. yes, sorry for this comment. I was reviewing an earlier patch-set and got confused. http://gerrit.ovirt.org/#/c/26996/23/packaging/dbscripts/upgrade/03_05_0330_add_numa_tables_and_columns.sql File packaging/dbscripts/upgrade/03_05_0330_add_numa_tables_and_columns.sql: Line 44: -- Create partial index for vds cpu statistics Line 45: CREATE INDEX IDX_vds_cpu_statistics_vds_id ON vds_cpu_statistics(vds_id); Line 46: Line 47: -- Numa nodes internal connection table Line 48: CREATE TABLE vm_vds_numa_node_map > IMHO this should be implemented as separate tables one for vms and one for Please provide an article explaining that. I can find several articles that suggest otherwise. Line 49: ( Line 50: id UUID NOT NULL, Line 51: vm_numa_node_id UUID NOT NULL, Line 52: vds_numa_node_id UUID, Line 47: -- Numa nodes internal connection table Line 48: CREATE TABLE vm_vds_numa_node_map Line 49: ( Line 50: id UUID NOT NULL, Line 51: vm_numa_node_id UUID NOT NULL, > Also, this got a id and additional vm_numa_node_id and vds_numa_node_id this is a map table: it connects vNodes to pNodes. The vNode always exists, but the pNode can be floating (that's why we added vds_numa_node_index), to allow migration and numa pinning. Line 52: vds_numa_node_id UUID, Line 53: vds_numa_node_index SMALLINT, Line 54: is_pinned BOOLEAN DEFAULT false NOT NULL, Line 55: CONSTRAINT pk_vm_vds_numa_node_map PRIMARY KEY(id), -- To view, visit http://gerrit.ovirt.org/26996 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2507c084aa214bcfb65e860b11ed7dcf02af50cc Gerrit-PatchSet: 23 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Xiaolei Shi <xiao-lei....@hp.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Jason Liao <chuan.l...@hp.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Xiaolei Shi <xiao-lei....@hp.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
