Eli Mesika has posted comments on this change. Change subject: db: Numa support database implementation ......................................................................
Patch Set 25: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/26996/25/packaging/dbscripts/upgrade/post_upgrade/0010_add_object_column_white_list_table.sql File packaging/dbscripts/upgrade/post_upgrade/0010_add_object_column_white_list_table.sql: Line 81: END; $procedure$ Line 82: LANGUAGE plpgsql; Line 83: Line 84: select __temp_add_numa_columns(); Line 85: drop function __temp_add_numa_columns(); The whole SP is redundant , Please change all the code block to select fn_db_add_column_to_object_white_list('vds', 'auto_numa_balancing'); select fn_db_add_column_to_object_white_list('vds', 'is_numa_supported'); -- To view, visit http://gerrit.ovirt.org/26996 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2507c084aa214bcfb65e860b11ed7dcf02af50cc Gerrit-PatchSet: 25 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Xiaolei Shi <xiao-lei....@hp.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Jason Liao <chuan.l...@hp.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Xiaolei Shi <xiao-lei....@hp.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
