Gilad Chaplik has posted comments on this change. Change subject: db: Numa support database implementation ......................................................................
Patch Set 23: (2 comments) comments also in patch-set 21 http://gerrit.ovirt.org/#/c/26996/23/packaging/dbscripts/create_views.sql File packaging/dbscripts/create_views.sql: Line 1714: run_in_vds_numa_node.usage_cpu_percent as run_in_vds_numa_node_usage_cpu_percent, Line 1715: run_in_vds_numa_node.distance as run_in_vds_numa_node_distance Line 1716: FROM vm_vds_numa_node_map Line 1717: LEFT OUTER JOIN numa_node as vm_numa_node on vm_vds_numa_node_map.vm_numa_node_id = vm_numa_node.numa_node_id Line 1718: LEFT OUTER JOIN numa_node as run_in_vds_numa_node on vm_vds_numa_node_map.vds_numa_node_id = run_in_vds_numa_node.numa_node_id; Missing vds and vm views including numa fields. http://gerrit.ovirt.org/#/c/26996/23/packaging/dbscripts/upgrade/03_05_0330_add_numa_tables_and_columns.sql File packaging/dbscripts/upgrade/03_05_0330_add_numa_tables_and_columns.sql: Line 123: END IF; Line 124: END IF; Line 125: RETURN NULL; Line 126: END; $process_numa_node_count$ Line 127: LANGUAGE plpgsql; please remove. see ***. Line 128: Line 129: CREATE TRIGGER process_numa_node_count Line 130: AFTER INSERT OR DELETE ON numa_node -- To view, visit http://gerrit.ovirt.org/26996 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2507c084aa214bcfb65e860b11ed7dcf02af50cc Gerrit-PatchSet: 23 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Xiaolei Shi <xiao-lei....@hp.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Jason Liao <chuan.l...@hp.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Xiaolei Shi <xiao-lei....@hp.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
